Fix build failure with sqlite test

db/gorm.go

@@ -9,6 +9,10 @@ import (
 	_ "github.com/jinzhu/gorm/dialects/sqlite"   // Need for sqlite
 )
 
+const (
+	SqliteType = "sqlite3"
+)
+
 // Logger interface
 type Logger interface {
 	Print(v ...interface{})
@@ -32,7 +36,7 @@ func GormInit(conf *config.Config, logger Logger) (*gorm.DB, error) {
 		return nil, openErr
 	}
 
-	IsSqlite = conf.DBType == "sqlite"
+	IsSqlite = conf.DBType == SqliteType
 
 	connectionErr := db.DB().Ping()
 	if connectionErr != nil {
@@ -41,7 +45,13 @@ func GormInit(conf *config.Config, logger Logger) (*gorm.DB, error) {
 	}
 
 	// Negative MaxIdleConns means don't retain any idle connection
-	db.DB().SetMaxIdleConns(-1)
+	maxIdleConns := -1
+	if IsSqlite {
+		// sqlite doesn't like having a negative maxIdleConns
+		maxIdleConns = 10
+	}
+
+	db.DB().SetMaxIdleConns(maxIdleConns)
 	db.DB().SetMaxOpenConns(400)
 
 	if config.Environment == "DEVELOPMENT" {

db/gorm_test.go

@@ -26,7 +26,7 @@ func (logger *errorLogger) Print(values ...interface{}) {
 
 func TestGormInitSqlite(t *testing.T) {
 	conf := config.New()
-	conf.DBType = "sqlite3"
+	conf.DBType = SqliteType
 	conf.DBParams = ":memory:?cache=shared&mode=memory"
 	conf.DBLogMode = "detailed"