From 270cacb1d7aa69fb29e20a41e5cfcf3b25cfc04c Mon Sep 17 00:00:00 2001 From: Mohamed Ezzat Date: Wed, 27 Apr 2016 22:18:25 +0200 Subject: [PATCH] squid:S2039 - Member variable visibility should be specified (#279) --- .../pager/vertical/VerticalViewPagerImpl.java | 24 ++++++++-------- .../util/DynamicConcurrentMergeOperator.java | 28 +++++++++---------- .../widget/EndlessGridScrollListener.java | 2 +- .../widget/EndlessListScrollListener.java | 2 +- 4 files changed, 28 insertions(+), 28 deletions(-) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/vertical/VerticalViewPagerImpl.java b/app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/vertical/VerticalViewPagerImpl.java index 9f407b8e8..10e6fd171 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/vertical/VerticalViewPagerImpl.java +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/reader/viewer/pager/vertical/VerticalViewPagerImpl.java @@ -120,11 +120,11 @@ public class VerticalViewPagerImpl extends ViewGroup { private int mExpectedAdapterCount; static class ItemInfo { - Object object; - int position; - boolean scrolling; - float heightFactor; - float offset; + private Object object; + private int position; + private boolean scrolling; + private float heightFactor; + private float offset; } private static final Comparator COMPARATOR = new Comparator(){ @@ -1260,9 +1260,9 @@ public class VerticalViewPagerImpl extends ViewGroup { * contains that state. */ public static class SavedState extends BaseSavedState { - int position; - Parcelable adapterState; - ClassLoader loader; + private int position; + private Parcelable adapterState; + private ClassLoader loader; public SavedState(Parcelable superState) { super(superState); @@ -2946,23 +2946,23 @@ public class VerticalViewPagerImpl extends ViewGroup { /** * Width as a 0-1 multiplier of the measured pager width */ - float heightFactor = 0.f; + private float heightFactor = 0.f; /** * true if this view was added during layout and needs to be measured * before being positioned. */ - boolean needsMeasure; + private boolean needsMeasure; /** * Adapter position this view is for if !isDecor */ - int position; + private int position; /** * Current child index within the ViewPager that this view occupies */ - int childIndex; + private int childIndex; public LayoutParams() { super(FILL_PARENT, FILL_PARENT); diff --git a/app/src/main/java/eu/kanade/tachiyomi/util/DynamicConcurrentMergeOperator.java b/app/src/main/java/eu/kanade/tachiyomi/util/DynamicConcurrentMergeOperator.java index c72d52e17..2b18e417b 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/util/DynamicConcurrentMergeOperator.java +++ b/app/src/main/java/eu/kanade/tachiyomi/util/DynamicConcurrentMergeOperator.java @@ -17,8 +17,8 @@ import rx.subscriptions.CompositeSubscription; import rx.subscriptions.Subscriptions; public class DynamicConcurrentMergeOperator implements Operator { - final Func1> mapper; - final Observable workerCount; + private final Func1> mapper; + private final Observable workerCount; public DynamicConcurrentMergeOperator( Func1> mapper, @@ -37,14 +37,14 @@ public class DynamicConcurrentMergeOperator implements Operator { } static final class DynamicConcurrentMerge extends Subscriber { - final Subscriber actual; - final Func1> mapper; - final Queue queue; - final CopyOnWriteArrayList> workers; - final CompositeSubscription composite; - final AtomicInteger wipActive; - final AtomicBoolean once; - long id; + private final Subscriber actual; + private final Func1> mapper; + private final Queue queue; + private final CopyOnWriteArrayList> workers; + private final CompositeSubscription composite; + private final AtomicInteger wipActive; + private final AtomicBoolean once; + private long id; public DynamicConcurrentMerge(Subscriber actual, Func1> mapper) { @@ -121,10 +121,10 @@ public class DynamicConcurrentMergeOperator implements Operator { } static final class DynamicWorker { - final long id; - final AtomicBoolean running; - final DynamicConcurrentMerge parent; - final AtomicBoolean stop; + private final long id; + private final AtomicBoolean running; + private final DynamicConcurrentMerge parent; + private final AtomicBoolean stop; public DynamicWorker(long id, DynamicConcurrentMerge parent) { this.id = id; diff --git a/app/src/main/java/eu/kanade/tachiyomi/widget/EndlessGridScrollListener.java b/app/src/main/java/eu/kanade/tachiyomi/widget/EndlessGridScrollListener.java index a4d74d550..efad9c911 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/widget/EndlessGridScrollListener.java +++ b/app/src/main/java/eu/kanade/tachiyomi/widget/EndlessGridScrollListener.java @@ -10,7 +10,7 @@ public class EndlessGridScrollListener extends RecyclerView.OnScrollListener { private int previousTotal = 0; // The total number of items in the dataset after the last load private boolean loading = true; // True if we are still waiting for the last set of data to load. private int visibleThreshold = 5; // The minimum amount of items to have below your current scroll position before loading more. - int firstVisibleItem, visibleItemCount, totalItemCount; + private int firstVisibleItem, visibleItemCount, totalItemCount; private GridLayoutManager layoutManager; diff --git a/app/src/main/java/eu/kanade/tachiyomi/widget/EndlessListScrollListener.java b/app/src/main/java/eu/kanade/tachiyomi/widget/EndlessListScrollListener.java index b5fcfa940..1667d15c8 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/widget/EndlessListScrollListener.java +++ b/app/src/main/java/eu/kanade/tachiyomi/widget/EndlessListScrollListener.java @@ -10,7 +10,7 @@ public class EndlessListScrollListener extends RecyclerView.OnScrollListener { private int previousTotal = 0; // The total number of items in the dataset after the last load private boolean loading = true; // True if we are still waiting for the last set of data to load. private int visibleThreshold = 5; // The minimum amount of items to have below your current scroll position before loading more. - int firstVisibleItem, visibleItemCount, totalItemCount; + private int firstVisibleItem, visibleItemCount, totalItemCount; private LinearLayoutManager layoutManager;