03ea72595d
* Initial Commit for OAuth API This builds and run and return the right error. Need to test it and then adding all users as possible client * Added mising dependency * just compile already... * Fixing template test * Imrpovements Moved db stuff in models Added some tests Added form in modpanel to add/update a client Added controllers for add/update of client * Added Forms + speed improvements Controller oauth client listing + html Controller oauth client delete + messages Messages on comment delete New ES config that disable ES if set to false. Improve load speed on local development Fix a load config bug Fix index admin & translation string sign_out broken by @ewhal * Sanitize empty strig in form array + css Multiple empty array of strings are sanitized for the oauth client create form Added some css for the form display * Upload and Create form works * Fix splitting response types * Removing required on secret when updating * fix travis error * Fix travis template test * Update dependency * Moved to jinzhu instead of azhao * randomizen secret on creation * Final touch on oath api improved display name fix grant form csrf fix login csrf on oauth * Fix gorm test * fix template test * Fixing deleted dependency issue * Make travis faster * Fix typo * Fix csrf for api calls * This shouldn't be exempt * Removing hard coded hash @ewhal Don't forget to replace the hash in tokens.go with another one * Added an example on how to use OAuth middleware * Renamed fosite utils to oauth2 utils
2,7 Kio
Contributing to GoRequest
Thanks for taking the time to contribute!!
GoRequest welcomes any kind of contributions including documentation, bug reports, issues, feature requests, feature implementations, pull requests, helping to manage and answer issues, etc.
Code Guidelines
To make the contribution process as seamless as possible, we ask for the following:
- Go ahead and fork the project and make your changes. We encourage pull requests to allow for review and discussion of code changes.
- When you’re ready to create a pull request, be sure to:
- Have test cases for the new code.
- Follow GoDoc guideline and always add documentation for new function/variable definitions.
- Run
go fmt. - Additonally, add documentation to README.md if you are adding new features or changing functionality.
- Squash your commits into a single commit.
git rebase -i. It’s okay to force update your pull request withgit push -f. - Make sure
go test ./...passes, andgo buildcompletes. - Follow the Git Commit Message Guidelines below.
Writing Commit Message
Follow this blog article. It is a good resource for learning how to write good commit messages, the most important part being that each commit message should have a title/subject in imperative mood starting with a capital letter and no trailing period: "Return error when sending incorrect JSON format", NOT "returning some error." Also, if your commit references one or more GitHub issues, always end your commit message body with See #1234 or Fixes #1234. Replace 1234 with the GitHub issue ID. The last example will close the issue when the commit is merged into master.
Sending a Pull Request
Due to the way Go handles package imports, the best approach for working on a fork is to use Git Remotes. You can follow the instructions below:
-
Get the latest sources:
go get -u -t github.com/parnurzeal/gorequest/... -
Change to the GoRequest source directory:
cd $GOPATH/src/github.com/parnurzeal/gorequest -
Create a new branch for your changes (the branch name is arbitrary):
git checkout -b issue_1234 -
After making your changes, commit them to your new branch:
git commit -a -v -
Fork GoRequest in Github.
-
Add your fork as a new remote (the remote name, "fork" in this example, is arbitrary):
git remote add fork git://github.com/USERNAME/gorequest.git -
Push the changes to your new remote:
git push --set-upstream fork issue_1234 -
You're now ready to submit a PR based upon the new branch in your forked repository.